Quality Guardian

function processOrder(order) {
  if (order) {
    if (order.items) {
      if (order.items.length > 0) {
        if (order.customer) {
          if (order.customer.active) {
            // Finally, the actual logic...
            return calculateTotal(order)
          }
        }
      }
    }
  }
  return null
}

5 níveis de aninhamento — difícil de ler e manter

function processOrder(order) {
  if (!isValidOrder(order)) return null
  return calculateTotal(order)
}

function isValidOrder(order) {
  return order?.items?.length > 0
    && order?.customer?.active
}

Extrair cláusula de guarda, achatar estrutura

function calculateDiscount(total) {
  if (total > 100) return total * 0.1
  if (total > 50) return total * 0.05
  return 0
}

Números mágicos: o que significam 100, 50, 0.1?

const DISCOUNT_TIERS = {
  PREMIUM: { threshold: 100, rate: 0.10 },
  STANDARD: { threshold: 50, rate: 0.05 },
}

function calculateDiscount(total) {
  const tier = Object.values(DISCOUNT_TIERS)
    .find(t => total > t.threshold)
  return tier ? total * tier.rate : 0
}

Extrair constantes com nomes significativos

function calc(d, t) {
  const r = d / t
  const x = r * 3.6
  return x
}

Nomes crípticos: d, t, r, x não dizem nada

const MS_TO_KMH = 3.6

function calculateSpeedKmh(distanceMeters, timeSeconds) {
  const metersPerSecond = distanceMeters / timeSeconds
  return metersPerSecond * MS_TO_KMH
}

Nomes descritivos que explicam o propósito